kit: extract CommonSshOptions into ssh_options.rs#280
Open
tnk4on wants to merge 1 commit into
Open
Conversation
cgwalters
approved these changes
Jun 10, 2026
Collaborator
|
OK, problem is you need to rebase to pick up CI fixes. But if we went to merge queues, then I think we can avoid that in the future. |
Extract CommonSshOptions and SshConnectionOptions into a dedicated cross-platform module. These types were embedded in ssh.rs alongside Linux-specific container SSH logic, making them unavailable to other backends. Assisted-by: Antigravity (Claude Opus 4.6) Signed-off-by: Shion Tanaka <shtanaka@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
CommonSshOptionsandSshConnectionOptionsfromssh.rsinto a dedicatedssh_options.rsmodule. These types were embedded alongside Linux-specific container SSH logic, making them unavailable to other backends.The
sshmodule re-exports the types so existing callers are unchanged.Prep for #259
Assisted-by: Claude Code (Claude Opus 4.6)